search

ethz-asl / robot_control

1 stars 2 forks source link

Panda #5

Closed kekeblom closed 4 years ago

kekeblom commented 4 years ago

Addresses issue #1.

I moved all the mesh files to git large file storage so that diffs are cleaner and generally operations are faster.

The panda description files are generated from https://github.com/mkrizmancic/franka_gazebo. I'm not sure what the right way to attribute credits are. One option would be to add that repository as a submodule and a step to run xacro. Another to just add the license/copyright notice into the panda directory.

Can be tested by running python test/controllers/test_op_space_controller.py

Runs ok. The default joint configuration is a bit weird. Maybe that should be adjusted somehow.

grizzi commented 4 years ago

Looks good to me. We can add what you mentioned as TODOs in the project, just to make sure they are not left behind.

grizzi commented 4 years ago

@kekeblom I have just added the rule for a mandatory reviewer for each PR and I would suggest the rule that who opens the PR is who merges it after approval.

kekeblom commented 4 years ago

Might be faster if the one who approves it merges. Also puts more responsibility on the merger as they need to be confident everything won't break.

grizzi commented 4 years ago

Right, ok than lets do this way from now on.