search

etrupja / MathHelper.io

You want an easy way to find the Area, Surface Area, Perimeter or Volume? Or you are looking for an easy way to find different equations like: Slope Of Line, Quadratic Equation, Standard Equation Of Circle, Quadratic Formula, Point Slope Equation or even Slope Intercept Equation? Then check out MathHelper.io nuget package to help you with your math problems.
https://www.nuget.org/packages/MathHelper.io
0 stars 1 forks source link

General practices and tipps #2

Open MiroslavMikus opened 6 years ago

MiroslavMikus commented 6 years ago

Hey so here are some great practices IMO and TODOs for them:

Change target framework from dot net core to dot net standard. As result, this framework can be used on regular .NET, .Net Core, Xamarin, UWP (and more) instead of only .NET core.

An invalid operation should throw an exception. If someone try to divide with 0 he/she should get an intermediate response instead of 'null'. If you decide to do this here are some todos:

Inconsistent naming convention -> some arguments are a whole word and some only one letter. I would go for naming with a whole word (even if you have a great docu). Therefore signatures like this ' public static double Rectange(this double l, double w)' shall be improved.

Inconsistent syntax -> some 'one line' methods are written with the expression body ( => or rocket) syntax and some with the old one. It this case I would go for the rocket syntax.

MiroslavMikus commented 6 years ago

Unit Tests should test only one thing/functionality