search

evaera / RbxSync

[ARCHIVED] Third party IDE support for Roblox Studio.
GNU General Public License v3.0
31 stars 12 forks source link

RSync 1.3.1 no longer working on latest roblox. #15

Closed ToastEngine closed 7 years ago

ToastEngine commented 7 years ago

No output errors. Plugin no longer showing in plugins bar. Plugin still exists in the plugin folder though.

GixxerK3 commented 7 years ago

I'm not sure exactly what evaera is trying to guard against but if you change line 380 of rsync.lua from:

if game.Name:match("Place[%d+]") and (game:GetService("RunService"):IsClient() and game:GetService("RunService"):IsServer()) then

to

if game:GetService("RunService"):IsStudio() and (game:GetService("RunService"):IsClient() and game:GetService("RunService"):IsServer()) then

it will get RSync working again. Seems to me like that's along the lines of what the original code was implying.

I'm not certain that what she was after but I'll submit a pull request for it and see what happens.

GixxerK3 commented 7 years ago

Actually, I see what she was after now and the code I gave isn't it. What I gave will get you editing again but Studio will crash when you run your game and then stop it. I'll see if I can figure out a better way...

evaera commented 7 years ago

I will investigate this when I get off work

GixxerK3 commented 7 years ago

Got the pull request in. Hopefully that gets everything resolved.

In the meantime, you can change line 380 to the following 2 lines:

game:GetService("RunService").Heartbeat:Wait()
if (game:GetService("RunService"):IsStudio() and not game:GetService("RunService"):IsRunning()) and (game:GetService("RunService"):IsClient() and game:GetService("RunService"):IsServer()) then