evaera / RbxSync

[ARCHIVED] Third party IDE support for Roblox Studio.
GNU General Public License v3.0
31 stars 12 forks source link

Persistent Mode doesnt use the correct StringValue #7

Closed DianaNites closed 7 years ago

DianaNites commented 7 years ago

With the RSync plugin, ANY new StringValue's placed in HTTPService, regardless of name, has it's Value used for Persistent Mode.

I realize this may be a limitation due to the fact you dont have a real way to enable/disable Persistent Mode, and you cant just poll HttpService in a loop to see if it has a StringValue named PlaceName, hence the presumed ChildAdded hook.

In addition, the event isnt ever disconnected, so if you add MULTIPLE String Values into HttpService, ALL of them are monitored for changes to Value, and then the RSync plugin does weird things when you try to change the different ones.

ALSO, the event runs even if a StringValue named PlaceName ALREADY EXISTS in HttpService.

Could be solved, i suppose, by just renaming the first StringValue placed into HttpService to the correct name and then disconnecting from the event, using solely that StringValue, and not connecting at all if a StringValue by the correct name already exists.