search

evaera / RbxSync

[ARCHIVED] Third party IDE support for Roblox Studio.
GNU General Public License v3.0
31 stars 12 forks source link

Fixed Values having multiple `Changed` Connections #8

Closed Validark closed 7 years ago

Validark commented 7 years ago

Previously, every time Changed fired on a StringValue it would open up another Changed connection. This behavior is now corrected.

Relevant lines: 335, 344, 345

In addition, checking whether the Object is named PlaceName and is a StringValue only occurs once.

Should fix Issue#7

evaera commented 7 years ago

@Narrev hmm, but does this still work if someone were to drop a new StringValue into HttpService, then rename it to "PlaceName", then change the value to something? When the new value is inserted, it won't already have the right values, so that's why it was done like the way I did it (even though it was flawed)

Validark commented 7 years ago

Updated to meet your described behavior