evekb / evedev-kb

EVE Killboard
www.evekb.org
41 stars 22 forks source link

Fix 'Ignore pages' cache config processing #108

Open Gadicuz opened 5 years ago

Gadicuz commented 5 years ago

Problem description: Function cache::shouldCache($page) returns false for any page on 'Ignore pages' list and hence function cache::check($page) doesn't call ob_start() for the page. Fucntion cache::generate() is called without arguments. Call cache::shouldCache() without arguments results true for the same 'ignored' page in cache::generate(). Function cache::generate() caches page data from output buffer and adds some headers. But no buffer was created in cache::check() as the page is on 'Ignore page' list. This leads to invalid cache content (no buffer available) and failed headers 'Etag' and 'Last-Modified' (body already sent).

Moreover in cache::generate() function call to self::expiry($page) always with $page = null.

PS. file class.cache.php still needs some refactoring.