search

everydotorg / donate-button

A free donate and p2p fundraising button so nonprofit websites can accept cryptocurrency, stocks, and cash - credit, debit, bank, PayPal, Venmo, Apple Pay, Google Pay.
https://www.every.org
MIT License
48 stars 7 forks source link

Proper cloudinary flags #322

Closed markulrich closed 1 year ago

markulrich commented 2 years ago

The cover and logo do not use f_auto,q_auto like they should

markulrich commented 1 year ago

See https://cloudinary.com/documentation/image_optimization

markulrich commented 1 year ago

https://github.com/everydotorg/donate-button/blob/main/packages/donate-button-next/src/components/widget/api/get-nonprofit-info.ts#L8

nate-j5 commented 1 year ago

Will take a look at this tomorrow.

markulrich commented 1 year ago

Adding some details, while currently the getCloudinaryUrl will return a string like https://res.cloudinary.com/everydotorg/image/upload/profile_pics/ftwf0qtym2defaahzfrh (22 kb jpeg on my machine) we want it to return https://res.cloudinary.com/everydotorg/image/upload/f_auto,q_auto/profile_pics/ftwf0qtym2defaahzfrh (13 kb avif on my machine)