everypolitician / gender-balance

Crowdsourcing platform for gathering gender information about politicians to improve the data in EveryPolitician
gender-balance.org
15 stars 3 forks source link

Remove text labels on back buttons #31

Closed tmtmtmtm closed 9 years ago

tmtmtmtm commented 9 years ago

It seems like "< Terms" is going to take you to a Terms & Conditions type page, rather than back to the homepage for the country.

zarino commented 9 years ago

Maybe it should be the country name?

zarino commented 9 years ago

Or, even better, maybe a back arrow without any text, since space in that header is going to be at a premium if the app name is longer than 12 characters.

tmtmtmtm commented 9 years ago

:+1: for just a back arrow. I don't think there's any need for the country name.

zarino commented 9 years ago

Ok, I've renamed the ticket. We have a similar issue on the country page, where the back link is titled "< Countries", and on a 320px wide screen, that's a very tight fit.

Removing the text label for the button should be a simple way to avoid both issues. Obviously the back button in the browser will also work too.

zarino commented 9 years ago

Pull request here: https://github.com/everypolitician/gender-crowdsourcing/pull/44