search

evewspace / eve-wspace

Wormhole mapping and corporation management for Eve Online.
Apache License 2.0
86 stars 51 forks source link

Suggestion: Add option to delete missing sigs when pasting from the scanner #170

Open ChrisBaker97 opened 9 years ago

ChrisBaker97 commented 9 years ago

Tripwire has a useful feature that, for a moment after the user pastes in new signatures, shows a link that automatically deletes anything that was present before—but is now missing—from the new paste. This is quite handy when inserting a complete and current scan of a system, as it ensures that everything is up to date, and that there are no old signatures present.

Zumochi commented 9 years ago

:+1: good idea, I always have to manually check all signatures now, which can be quite a hassle in shattered systems :stuck_out_tongue:

lynxart commented 9 years ago

This sounds like something really useful... I just did some work on the signatures anyway, will have a look!

marbindrakon commented 9 years ago

This could pretty easily be done as a check box on the bulk import form or at least as a configurable persistent behavior. If lynxart doesn't have time to do it, I will try to get it in for next release myself.

lynxart commented 9 years ago

@marbindrakon If I try to add the checkbox, should I start from my latest code (pull request #167) or from your main develop branch? I am new to working on a project like this, always did things on my own in the past, and I don't want to cause unnecessary work.

Zumochi commented 9 years ago

@lynxart It's probably best to branch off of Marbin's main develop branch. When there are any merge issues those can be solved with the PR. That's generally best practice because you never know if a PR will actually get accepted or not.

lynxart commented 9 years ago

OK!

Yracka commented 9 years ago

I suggest that it needs an undo feature too. Tripwire has such a feature and it was easy to make a mistake and delete a pile of sigs you didn't want too.

raphendyr commented 8 years ago

Could EWS show missing signatures with red background for example. This way user could remove the bookmarks too? Of course checkbox for full import would work too with list of removed signatures.