search

evewspace / eve-wspace

Wormhole mapping and corporation management for Eve Online.
Apache License 2.0
86 stars 51 forks source link

[current master] Add system doesn't appear to set wormhole type or status #240

Closed raphendyr closed 7 years ago

raphendyr commented 8 years ago

New UI doesn't appear to handle add system window properly. I try to allocate time to look into this, as it's quite big thing for us.

Anycase, wanted to let others know.

Zumochi commented 8 years ago

Interesting as it seems to work for me. So you get the popup, fill in type/status etc and it remains k162?

On Thu, Feb 18, 2016 at 5:15 PM, Jaakko Kantojärvi notifications@github.com wrote:

New UI doesn't appear to handle add system window properly. I try to allocate time to look into this, as it's quite big thing for us.

Anycase, wanted to let others know.

Reply to this email directly or view it on GitHub: https://github.com/evewspace/eve-wspace/issues/240

raphendyr commented 8 years ago

Exactly. Might be that I broke something with my local "disable reddit, rss" patch. I think its specially the automatic popup that comes when going trough wormhole as the manual "add system" gets correct colors fot normal, first shrink etc.

raphendyr commented 8 years ago

Also, the UI is different on my chomium and IGB. Jsut noticed when tested this.

edit: this was because the width of the IGB. I have it smaller than expected it appears.

raphendyr commented 8 years ago

Yeps. The "options > add system" works, but not the one that poups when you enter new system.

raphendyr commented 8 years ago

Reading the code... It appears that automatic dialog is handled a bit differently. The update/ call returns html for the dialog. It returns tempalte templates/igb_system_add_dialog.html instead of the manual templates/add_system_box.html.

I think we a) should return just info "show add sytem dialog with system name foobar" and then on client call the addsystem function or b) return the same template with value for the system name.

Anycase having 2 different templates for same data is a bit error prone.

raphendyr commented 8 years ago

Ok. Even though the layout is broken this might not be related to that. Apparently if the dialog window is moved, it wil lreset all of the settings, thus anything changed will be reseted. Interesting bug.

Maarten28 commented 7 years ago

The PR is in develop now, so should be fixed now.