search

evgenyneu / js-evaluator-for-android

A library for running JavaScript in Android apps.
MIT License
487 stars 84 forks source link

Bugfix/fix leaking listener #40

Closed clydzik closed 7 years ago

clydzik commented 7 years ago

fixed leaking listener (#39) by switch to key/value structure. it was difficult on index based one also cleaned git ignore a bit what produce bigger PR by side effect

evgenyneu commented 7 years ago

Thank you very much. Do you think it is worth adding a unit test that verifies that the callback has been removed from the list?

clydzik commented 7 years ago

I think I did it in testJsCallFinished_runsCallbackAndRemove If this is not clean enough let me know.

evgenyneu commented 7 years ago

Yes, sorry, I missed that. All good :)