evgenyneu / moa

An image download extension of the image view written in Swift for iOS, tvOS and macOS.
MIT License
332 stars 45 forks source link

Some error after update to last version 5.0.0 #10

Closed yop289 closed 7 years ago

yop289 commented 8 years ago

Hi

I'm having same errors after install version 5.0

File: MoaHttpSession.swift configuration.timeoutIntervalForRequest = Moa.settings.requestTimeoutSeconds configuration.timeoutIntervalForResource = Moa.settings.requestTimeoutSeconds configuration.httpMaximumConnectionsPerHost = Moa.settings.maximumSimultaneousDownloads configuration.requestCachePolicy = Moa.settings.cache.requestCachePolicy

MoaHttpSession.swift:26:5: Function 'configuration' was used as a property; add () to call it

File: MoaString.swift

if ignoreCase { _ = options.insert(NSString.CompareOptions.caseInsensitive) }
if ignoreDiacritic { _ = options.insert(NSString.CompareOptions.diacriticInsensitive) }

'NSString.CompareOptions' has no member 'caseInsensitive' 'NSString.CompareOptions' has no member 'diacriticInsensitive'

Best regards Davjd

evgenyneu commented 8 years ago

Hi Davjd,

Thank you for reporting. Version 5 is compatible with Xcode 8 beta 2, they did minor renamings in Swift libraries. If you are using an older version of Xcode please install a previous version of moa. Here are the instructions:

https://github.com/evgenyneu/moa/wiki/Legacy-Swift-versions

Let me know how it goes.

Regards

yop289 commented 8 years ago

Hi

I was using Xcode 8 beta 2, at the end I uninstalled the pod version and installed the library directly and all works fine.

Thanks

evgenyneu commented 8 years ago

Thanks for the information. I was trying to recreate your issue today but everything worked for me.

  1. First, I Installed version 4 of moa for Xcode beta 1. OK
  2. Then installed version 5 and opened it in beta 2. OK

Version 5 should be working with CocoaPods in beta 2 unless I am missing something. If anyone else has the similar problem feel free to report.

evgenyneu commented 7 years ago

@yop289 is this issue resolved?

evgenyneu commented 7 years ago

Closing the issue, feel free to reopen if needed.