evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft
https://rclootcouncil.com
GNU Lesser General Public License v3.0
19 stars 29 forks source link

Error Version 3.0 #196

Closed TopoDiFogna closed 4 years ago

TopoDiFogna commented 4 years ago

Hi great work with keeping this Addon going.

I saw that you released a new v3 version, I've installed it and at login I get this error:

Message: Interface\AddOns\RCLootCouncil\core.lua:976: attempt to index global 'addon' (a nil value)
Time: Fri Oct 16 16:15:17 2020
Count: 1
Stack: Interface\AddOns\RCLootCouncil\core.lua:976: attempt to index global 'addon' (a nil value)
[string "@Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua"]:146: in function <Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:144>
[string "=[C]"]: ?
[string "@Interface\AddOns\RCLootCouncil\core.lua"]:976: in function `?'
[string "@Interface\AddOns\ElvUI\Libraries\Ace3\AceTimer-3.0\AceTimer-3.0.lua"]:55: in function <...s\ElvUI\Libraries\Ace3\AceTimer-3.0\AceTimer-3.0.lua:50>

Locals: private = <table> {
 ThrowError = <function> defined @Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:46
 DoesErrorExist = <function> defined @Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:87
 ClearOldErrors = <function> defined @Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:107
 SanitizeLine = <function> defined @Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:83
 MAX_STACK_DEPTH = 10
 log = <table> {
 }
 ErrorHandler = <function> defined @Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:116
 IncrementErrorCount = <function> defined @Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:77
 NewError = <function> defined @Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:50
 IsRCLootCouncilError = <function> defined @Interface\AddOns\RCLootCouncil\Core\ErrorHandler.lua:94
}
orig_errorhandler = <function> defined @Interface\SharedXML\SharedBasicControls.lua:355

https://github.com/evil-morfar/RCLootCouncil2/blob/4d9ab98ffd4e85ea68aa9f15a02449c86d9c62a0/core.lua#L976 Should this addon variable be addonTable?

(I'm a developer myself but I don't know anything about Lua and WoW addon programming, I was just curious and looking @ the code)

evil-morfar commented 4 years ago

It should be self instead of addon (although addonTable refers to both RCLootCouncil and self in this case). Guess that's what happens when you test unguided on the ptr

TopoDiFogna commented 4 years ago

Glad it is an easy fix, how can I contribute to test and debug this addon now that 9.0.1 is live?

evil-morfar commented 4 years ago

You can try out as much as possible and see if there's anything else like this I've missed. I'm on vacation, so I don't have access to the game

TopoDiFogna commented 4 years ago

Other few things I found:

Other errors that I don't know how to fix:

Locals:


* Closing voting frame aborting:

Message: Interface\AddOns\RCLootCouncil\core.lua:2255: Usage: Ambiguate(fullName, context) Time: Fri Oct 16 18:37:52 2020 Count: 1 Stack: Interface\AddOns\RCLootCouncil\core.lua:2255: Usage: Ambiguate(fullName, context)

string "=[C]": in function Ambiguate' [string "@Interface\AddOns\RCLootCouncil\core.lua"]:2255: in functionAmbiguate' [string "@Interface\AddOns\RCLootCouncil\core.lua"]:2480: in function OnSessionEndReceived' [string "@Interface\AddOns\RCLootCouncil\core.lua"]:2398: in function_onNext' [string "@Interface\AddOns\RCLootCouncil\Classes\Lib\RxLua\Observer.lua"]:30: in function onNext' [string "@Interface\AddOns\RCLootCouncil\Classes\Lib\RxLua\Subjects\Subject.lua"]:57: in functionnext' [string "@Interface\AddOns\RCLootCouncil\Classes\Services\Comms.lua"]:158: in function `FireCmd' [string "@Interface\AddOns\RCLootCouncil\Classes\Services\Comms.lua"]:153: in function <...face\AddOns\RCLootCouncil\Classes\Services\Comms.lua:134>

[string "@Interface\AddOns\RCLootCouncil\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...cil\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@Interface\AddOns\RCLootCouncil\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire' [string "@Interface\AddOns\RCLootCouncil\Libs\AceComm-3.0\AceComm-3.0.lua"]:264: in function <...ddOns\RCLootCouncil\Libs\AceComm-3.0\AceComm-3.0.lua:246>

Locals:


* Awarding an item

Message: Interface\AddOns\RCLootCouncil\ml_core.lua:1180: attempt to call method 'GetItemLevelText' (a nil value) Time: Fri Oct 16 18:39:27 2020 Count: 1 Stack: Interface\AddOns\RCLootCouncil\ml_core.lua:1180: attempt to call method 'GetItemLevelText' (a nil value) string "=[C]": in function GetItemLevelText' [string "@Interface\AddOns\RCLootCouncil\ml_core.lua"]:1180: in functionfunc' [string "@Interface\AddOns\RCLootCouncil\ml_core.lua"]:1220: in function AnnounceAward' [string "@Interface\AddOns\RCLootCouncil\ml_core.lua"]:964: in function <Interface\AddOns\RCLootCouncil\ml_core.lua:955> [string "@Interface\AddOns\RCLootCouncil\ml_core.lua"]:1056: in functionAward' [string "@Interface\AddOns\RCLootCouncil\ml_core.lua"]:1588: in function `on_click' [string "@Interface\AddOns\RCLootCouncil\Libs\LibDialog-1.0\LibDialog-1.0.lua"]:512: in function <...s\RCLootCouncil\Libs\LibDialog-1.0\LibDialog-1.0.lua:506>

Locals:


* On loot setting Award Later and closing the window

Message: Interface\AddOns\RCLootCouncil\core.lua:2255: Usage: Ambiguate(fullName, context) Time: Fri Oct 16 18:40:56 2020 Count: 1 Stack: Interface\AddOns\RCLootCouncil\core.lua:2255: Usage: Ambiguate(fullName, context)

string "=[C]": in function Ambiguate' [string "@Interface\AddOns\RCLootCouncil\core.lua"]:2255: in functionAmbiguate' [string "@Interface\AddOns\RCLootCouncil\core.lua"]:2480: in function OnSessionEndReceived' [string "@Interface\AddOns\RCLootCouncil\core.lua"]:2398: in function_onNext' [string "@Interface\AddOns\RCLootCouncil\Classes\Lib\RxLua\Observer.lua"]:30: in function onNext' [string "@Interface\AddOns\RCLootCouncil\Classes\Lib\RxLua\Subjects\Subject.lua"]:57: in functionnext' [string "@Interface\AddOns\RCLootCouncil\Classes\Services\Comms.lua"]:158: in function `FireCmd' [string "@Interface\AddOns\RCLootCouncil\Classes\Services\Comms.lua"]:153: in function <...face\AddOns\RCLootCouncil\Classes\Services\Comms.lua:134>

[string "@Interface\AddOns\RCLootCouncil\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...cil\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@Interface\AddOns\RCLootCouncil\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire' [string "@Interface\AddOns\RCLootCouncil\Libs\AceComm-3.0\AceComm-3.0.lua"]:264: in function <...ddOns\RCLootCouncil\Libs\AceComm-3.0\AceComm-3.0.lua:246>

Locals:

* In Loot window hovering with the mouse on the corruption value for an item

Message: ...terface\AddOns\RCLootCouncil\Modules\votingFrame.lua:1374: attempt to call method 'SetBackdropStyle' (a nil value) Time: Fri Oct 16 18:43:12 2020 Count: 4 Stack: ...terface\AddOns\RCLootCouncil\Modules\votingFrame.lua:1374: attempt to call method 'SetBackdropStyle' (a nil value) string "=[C]": in function `SetBackdropStyle' [string "@Interface\AddOns\RCLootCouncil\Modules\votingFrame.lua"]:1374: in function <...terface\AddOns\RCLootCouncil\Modules\votingFrame.lua:1358> [string "@Interface\AddOns\RCLootCouncil\Modules\votingFrame.lua"]:1421: in function <...terface\AddOns\RCLootCouncil\Modules\votingFrame.lua:1420>

Locals:


* Opening the sync window: (it also leaves a dropdown visible on the screen)

Message: Interface\AddOns\RCLootCouncil\Modules\Sync.lua:181: attempt to call method 'RGBToHex' (a nil value) Time: Fri Oct 16 18:44:02 2020 Count: 1 Stack: Interface\AddOns\RCLootCouncil\Modules\Sync.lua:181: attempt to call method 'RGBToHex' (a nil value)

[string "@Interface\AddOns\RCLootCouncil\Modules\Sync.lua"]:181: in function <Interface\AddOns\RCLootCouncil\Modules\Sync.lua:178> [string "@Interface\AddOns\RCLootCouncil\Modules\Sync.lua"]:215: in function GetSyncTargetOptions' [string "@Interface\AddOns\RCLootCouncil\Modules\Sync.lua"]:272: in functionSpawn' [string "@Interface\AddOns\RCLootCouncil\Modules\Sync.lua"]:59: in function <Interface\AddOns\RCLootCouncil\Modules\Sync.lua:49>

[string "@Interface\AddOns\RCLootCouncil\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...Ons\RCLootCouncil\Libs\AceAddon-3.0\AceAddon-3.0.lua:65> [string "@Interface\AddOns\RCLootCouncil\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:527: in function <...Ons\RCLootCouncil\Libs\AceAddon-3.0\AceAddon-3.0.lua:520>

[string "@Interface\AddOns\RCLootCouncil\core.lua"]:516: in function ?' [string "@Interface\AddOns\RCLootCouncil\Libs\AceConsole-3.0\AceConsole-3.0.lua"]:94: in function?' [string "@Interface\FrameXML\ChatFrame.lua"]:5073: in function ChatEdit_ParseText' [string "@Interface\FrameXML\ChatFrame.lua"]:4737: in functionChatEdit_SendText' [string "@Interface\FrameXML\ChatFrame.lua"]:4773: in function `ChatEdit_OnEnterPressed'

Locals:



Bear in mind all this tests, where applicable, were done by using `/rc test` command and with only RCLootCouncil enabled as addon

Hope this will be useful 😄 
evil-morfar commented 4 years ago

I'll have a look at it later - thank you.

TopoDiFogna commented 4 years ago

Other thing I noticed: a lot of functions are called as addon:GetItemIDFromLink(d.lootWon) while they should be addon.Utils:GetItemIDFromLink(d.lootWon), since they are stored in the Utils table These are used a lot in the export functions

evil-morfar commented 4 years ago

Most of these were quite simple to fix.

The only one I didn't get was the ones with Usage: Ambiguate(fullName, context) (both are essentially the same). The code seems correct, but might be missing something. If it happens again I would very much like a look at your SV, as it should shed more light on it.

TopoDiFogna commented 4 years ago

Tested again with the latest commit, few errors are still there:

  1. Hovering on corruption value on voting frame (corruption is gone, this column shuold be removed?)
  2. Aborting a vote
  3. Award later option

RCLootCouncil.txt I've attached a clean SV file after reproducing these errors

TopoDiFogna commented 4 years ago

Trying to minimize the addon window also gives

Message: Interface\AddOns\RCLootCouncil\UI\Widgets\Frame.lua:151: attempt to call method 'Debug' (a nil value)
Time: Fri Oct 16 23:03:46 2020
Count: 2
Stack: Interface\AddOns\RCLootCouncil\UI\Widgets\Frame.lua:151: attempt to call method 'Debug' (a nil value)
[string "=[C]"]: in function `Debug'
[string "@Interface\AddOns\RCLootCouncil\UI\Widgets\Frame.lua"]:151: in function `Minimize'
[string "@Interface\AddOns\RCLootCouncil\UI\Widgets\Frame.lua"]:120: in function <Interface\AddOns\RCLootCouncil\UI\Widgets\Frame.lua:112>

Locals: 
evil-morfar commented 4 years ago

Odd, I thought I had removed the corruption column. I'm really starting to think I have lost some commits somewhere. Anyway, I'm on it, and thanks again.

s3thus commented 4 years ago

Posting here instead making new ticket :)

When updated to alpha 6, we are still getting this error when we try to test RCLC:

1x RCLootCouncil\Modules\votingFrame.lua:434: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function `pairs'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:434: in function `OnLootAckReceived'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:137: in function `_onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Observer.lua"]:30: in function `onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Subjects\Subject.lua"]:57: in function `next'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:163: in function `FireCmd'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:158: in function <...faceRCLootCouncil\Classes\Services\Comms.lua:139>
[string "=[C]"]: ?
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@Ace3\AceComm-3.0\AceComm-3.0-12.lua"]:264: in function <Ace3\AceComm-3.0\AceComm-3.0.lua:246>

In addition before test starts I get this msg: RCLootCouncil: Please wait a few seconds until all data has been synchronized.. Only person starting test has voting frame and can choose any response for items from test. Other 2 people with who I've tested it didn't get any pop up, just lua error.

Also voting frame for person who starts test shows double people like below image

evil-morfar commented 4 years ago

@s3thus Yeah, turns out there was multiple hidden issues in the alpha. If you're interested, you can get the latest v3.0 branch which should fix this. I'll probably release a new version off of it tomorrow.

s3thus commented 4 years ago

I've downloaded branch's head and replaced all my files with it but still there are errors:

when starting /rc test

2x RCLootCouncil\Modules\votingFrame.lua:1328: attempt to index field '?' (a nil value)
[string "@RCLootCouncil\Modules\votingFrame.lua"]:1328: in function `Filter'
[string "@GuildSearch\Libs\lib-st\Core.lua"]:443: in function `DoFilter'
[string "@GuildSearch\Libs\lib-st\Core.lua"]:339: in function `SortData'
[string "@GuildSearch\Libs\lib-st\Core.lua"]:592: in function `SetData'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:685: in function `BuildST'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:343: in function `Setup'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:216: in function `ReceiveLootTable'
[string "@RCLootCouncil\core.lua"]:2560: in function `OnLootTableReceived'
[string "@RCLootCouncil\core.lua"]:2428: in function `_onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Observer.lua"]:30: in function `onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Subjects\Subject.lua"]:57: in function `next'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:163: in function `FireCmd'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:158: in function <...faceRCLootCouncil\Classes\Services\Comms.lua:139>
[string "=[C]"]: ?
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@Ace3\AceComm-3.0\AceComm-3.0-12.lua"]:264: in function <Ace3\AceComm-3.0\AceComm-3.0.lua:246>

council window doesn't open at all for me when I start test.

when I /rc open after started test:

1x RCLootCouncil\Modules\votingFrame.lua:1362: attempt to index field '?' (a nil value)
[string "@RCLootCouncil\Modules\votingFrame.lua"]:1362: in function <RCLootCouncil\Modules\votingFrame.lua:1359>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `sort'
[string "@GuildSearch\Libs\lib-st\Core.lua"]:330: in function `SortData'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:555: in function `Update'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:664: in function `SwitchSession'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:195: in function `Show'
[string "@RCLootCouncil\core.lua"]:412: in function `?'
[string "@Ace3\AceConsole-3.0\AceConsole-3.0-7.lua"]:94: in function `?'
[string "@FrameXML\ChatFrame.lua"]:5073: in function <FrameXML\ChatFrame.lua:5019>
[string "=[C]"]: in function `ChatEdit_ParseText'
[string "@FrameXML\ChatFrame.lua"]:4737: in function `ChatEdit_SendText'
[string "@FrameXML\ChatFrame.lua"]:4773: in function <FrameXML\ChatFrame.lua:4769>
[string "=[C]"]: in function `ChatEdit_OnEnterPressed'
[string "*:OnEnterPressed"]:1: in function <[string "*:OnEnterPressed"]:1>

Locals:
table = <table> {
 sorttable = <table> {
 }
 filtered = <table> {
 }
 SortData = <function> defined @GuildSearch\Libs\lib-st\Core.lua:310
 cols = <table> {
 }
 GetDefaultHighlightBlank = <function> defined @GuildSearch\Libs\lib-st\Core.lua:450
 EnableSelection = <function> defined @GuildSearch\Libs\lib-st\Core.lua:484
 scrollframe = ScrollTable2ScrollFrame {
 }
 Hide = <function> defined @GuildSearch\Libs\lib-st\Core.lua:300
 offset = 0
 GetRow = <function> defined @GuildSearch\Libs\lib-st\Core.lua:599
 showing = true
 Show = <function> defined @GuildSearch\Libs\lib-st\Core.lua:290
 DefaultEvents = <table> {
 }
 SetWidth = <function> defined @GuildSearch\Libs\lib-st\Core.lua:43
 Filter = <function> defined @RCLootCouncil\Modules\votingFrame.lua:1325
 SetFilter = <function> defined @GuildSearch\Libs\lib-st\Core.lua:433
 SetData = <function> defined @GuildSearch\Libs\lib-st\Core.lua:589
 SetSelection = <function> defined @GuildSearch\Libs\lib-st\Core.lua:500
 DoFilter = <function> defined @GuildSearch\Libs\lib-st\Core.lua:438
 ClearSelection = <function> defined @GuildSearch\Libs\lib-st\Core.lua:492
 data = <table> {
 }
 GetCell = <function> defined @GuildSearch\Libs\lib-st\Core.lua:607
 fSelect = true
 rows = <table> {
 }
 SetHeight = <function> defined @GuildSearch\Libs\lib-st\Core.lua:38
 SetDisplayRows = <function> defined @GuildSearch\Libs\lib-st\Core.lua:122
 FireUserEvent = <function> defined @GuildSearch\Libs\lib-st\Core.lua:65
 GetDefaultHighlight = <function> defined @GuildSearch\Libs\lib-st\Core.lua:465
 rowHeight = 20
 displayRows = 15
 defaulthighlightblank = <table> {
 }
 defaulthighlight = <table> {
 }
 RegisterEvents = <function> defined @GuildSearch\Libs\lib-st\Core.lua:78
 head = ScrollTable2Head {
 }
 SetDefaultHighlightBlank = <function> defined @GuildSearch\Libs\lib-st\Core.lua:454
 Refresh = <function> defined @GuildSearch\Libs\lib-st\Core.lua:764
 IsRowVisible = <function> defined @GuildSearch\Libs\lib-st\Core.lua:624
 SetDisplayCols = <function> defined @GuildSearch\Libs\lib-st\Core.lua:203
 RowIsVisible = <function> defined @GuildSearch\Libs\lib-st\Core.lua:624
 SetDefaultHighlight = <function> defined @GuildSearch\Libs\lib-st\Core.lua:469
 events = <table> {
 }
 DoCellUpdate = <function> defined @GuildSearch\Libs\lib-st\Core.lua:518
 GetSelection = <function> defined @GuildSearch\Libs\lib-st\Core.lua:509
 frame = ScrollTable2 {
 }
 SetHighLightColor = <function> defined @GuildSearch\Libs\lib-st\Core.lua:57
 CompareSort = <function> defined @GuildSearch\Libs\lib-st\Core.lua:356
}
rowa = 3
rowb = 1
sortbycol = 5
column = <table> {
 comparesort = <function> defined @RCLootCouncil\Modules\votingFrame.lua:1359
 name = "Response"
 DoCellUpdate = <function> defined @RCLootCouncil\Modules\votingFrame.lua:1170
 sort = 1
 sortnext = 13
 colName = "response"
 width = 240
}
a = <table> {
 name = "Isvan"
 cols = <table> {
 }
}
b = <table> {
 name = "Meshsan"
 cols = <table> {
 }
}
(*temporary) = <function> defined @RCLootCouncil\core.lua:2282
(*temporary) = <table> {
 defaults = <table> {
 }
 ModuleChatCmd = <function> defined @RCLootCouncil\core.lua:2021
 StartHandleLoot = <function> defined @RCLootCouncil\core.lua:1589
 modules = <table> {
 }
 CancelTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:147
 GetTokenIlvl = <function> defined @RCLootCouncil\core.lua:912
 OptionsTable = <function> defined @RCLootCouncil\Modules\options.lua:138
 StopHandleLoot = <function> defined @Int
s3thus commented 4 years ago

In case here's my config file from WFT if that maybe help somehow: RCLootCouncil.zip

I admit I'm quite desperate to get this working as my guild depends on it for loot distribution and we will need it for Wed's evening raid (EU time) as I've not found any alternatives that could work until you will be able to fix it :<

evil-morfar commented 4 years ago

@s3thus Thanks, I'll have a look at it. I need it for my raid wednesday as well, so it'll be ready

evil-morfar commented 4 years ago

Did the one you were testing with also use the latest v3.0 branch? I should have mentioned it's not backwards compatible with older version. I couldn't exactly find the issue nor replicate it myself, but I added checks that should prevent it from happening.

evil-morfar commented 4 years ago

I'll close this issue with the release of 3.0-Beta.1. Please open a new issue should you encounter any issues with it.