search

evilsocket / xray

XRay is a tool for recon, mapping and OSINT gathering from public networks.
GNU General Public License v3.0
2.19k stars 297 forks source link

Small UI improvements (js,html) #35

Closed b4dnewz closed 7 years ago

b4dnewz commented 7 years ago

Hi, first of all, thank you for being so inspiring and for building such great tools.

Since I'm new to go and I'm still learning, I modified only angular code, which I used a lot in this years and I noticed in the Ui code some possible changes.

Turning scope.targets object into array enable some angular built in utility filters so I changed filter functions to use them. I've introduced a sort function for the fields Address, Isp, Country which can be usefull, I also added a reset button (right of search input) to clear all filter, both search text and orders and return to initial state.

By doing this the interface does the same as before, but without jquery and in a more "angular-way" I though that maybe you hate jquery as much as me 😄 and hopefully you will like these small changes.

Thanks again.

PS: The first and the last commit are mistakes, i've another branch where I tried travis for this project and added by mistake the file in this branch

evilsocket commented 7 years ago

that's great dude! thank you for the PR :D :+1:

b4dnewz commented 7 years ago

@evilsocket thank you man for being so "promiscuous" with the code, is a pleasure to use your tools and to see how you code, really! If you are interested I've tried also to use travis to automatically build your project you can see here the travis file and the build fails but complain about the name (obviously): build-report so I assume if placed in yours it will work.

You find this useful? I'm not sure if it is..so I didn't open a PR

evilsocket commented 7 years ago

nah not really