Not all, but some of the source files are not PEP 8 conform - e.g. lib/cfclient/cfclient.py. Fixing them wouldn't be hard. I've forked the repository and would be willing to reformat the "offending" code and pass it back as a pull request. However, if I bother doing it, I wouldn't want it to be an annoyance for anyone or never get pulled, so the question is is this wanted?
Advantages:
PEP 8 conformity - would be easier to read for people familiar with Python
All the advantages that come with that - might be easier to extend, refactor, etc.
Disadvantages:
On files I reformat, it would be an edit just about on every line, making it harder to merge
In the case of conflicts, it would be kind of annoying to find and correct them
So should I do it and send the pull request, or should we leave it the way it is?
evoggy
commented
10 years ago
Not all, but some of the source files are not PEP 8 conform - e.g. lib/cfclient/cfclient.py. Fixing them wouldn't be hard. I've forked the repository and would be willing to reformat the "offending" code and pass it back as a pull request. However, if I bother doing it, I wouldn't want it to be an annoyance for anyone or never get pulled, so the question is is this wanted?
Advantages:
Disadvantages:
So should I do it and send the pull request, or should we leave it the way it is?