Android plugin code update for new JS API

evothings / cordova-ble

Bluetooth Low Energy plugin for Cordova

http://www.evothings.com/

Apache License 2.0

242 stars 103 forks source link

Android plugin code update for new JS API #14

Closed ghost closed 10 years ago

ghost commented 10 years ago

The JavaScript API has changed, and the Android plugin needs updating.

Summary of changes:

Functions services, characteristics, and descriptors new return a list of found objects to the callback function.
Fields "serviceCount" and "characteristicCount" in object Service have been removed.
Field "descriptorCount" in object Characteristic has been removed.
Field "device" in ConnectInfo changed name to "deviceHandle".

There is a test program in file tests/test.html that can be used to verify that the plugins work consistently on Android and iOS.

fredrikeldh commented 10 years ago

It's "deviceHandle", not "deviceInfo".

fredrikeldh commented 10 years ago

My fork now contains a test-merge of your work. Does it look reasonable to you? https://github.com/fredrikeldh/cordova-ble/commits/master You may also want to see this commit on an off-branch: https://github.com/fredrikeldh/cordova-ble/commit/6340c29f23c1d42d219b7d0b1d921ad3bea7e893 IIRC, Android has a known limit of maximum 4 connections per app lifetime, which limits our tests.

ghost commented 10 years ago

Thanks a lot for the review! Changed "devieInfo" to "deviceHandle" (also in the info in the pull request). Great that the scanRecord not available on iOS is documented, and updates to the test and everything looks great. We can discuss further what to do with the close function.

ghost commented 10 years ago

Can this be closed?