evothings / cordova-ble

Bluetooth Low Energy plugin for Cordova
http://www.evothings.com/
Apache License 2.0
242 stars 103 forks source link

Consider adding scanRecord parsing to the native code #62

Closed thegecko closed 7 years ago

thegecko commented 9 years ago

The scanRecord parsing which appears in the easyble.js code would be so much more useful if it was added to the native Android code layer by default.

advertisementData and scanRecord data could then be accessed in a common way, perhaps even replacing the existing structures.

This would remove the need to (slowly) parse the data in JavaScript and make the API more consistent across iOS and Android devices.

BioPhoton commented 8 years ago

1+

ghost commented 7 years ago

Parsing of scan record on Android is now added the the BLE plugin, in JavaScript, not natively. Performance seems to be satisfactory. Let me know if there are needs for enhancement of performance or other issues, we can then revisit this issue and reopen.