search

ewilde / crane

Crane creates builds scripts so you don't have to
http://blog.cranebuild.com
Apache License 2.0
6 stars 2 forks source link

Add .gitattributes and .gitignore to crane init Template #87

Closed mrdavidlaing closed 9 years ago

mrdavidlaing commented 9 years ago

In line with Crane's Build you into the pit of success mantra; I'd like to propose that the project skeleton includes .gitignore and .gitattributes files that properly customise git behaviour for Windows / VS

mrdavidlaing commented 9 years ago

@ewilde, @kevholditch,

I think I've put the files in the right place, but I'm unsure how to write tests for this behaviour.

Could you possible show me how by committing some test stubs to the branch for me to complete.

Thanks!

ewilde commented 9 years ago

@mrdavidlaing thanks for the contrib, great spot! We also forgot to mention that in our contribution workflow we push to develop first and then got from develop to master at the end of a milestone. (we then causes an official choco package to get built and deployed by teamcity). I've raise #88 to address this

mrdavidlaing commented 9 years ago

@ewilde - Thanks for the test pointers.

Since it appears that github won't be adding the feature to change the target branch of a PR anytime soon, I'm going to close this PR and open a new one targeting the develop branch.