exafmm / pyexafmm

Kernel Independent Fast Multipole Method in Python
https://exafmm.github.io/pyexafmm
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

BUG: Accuracy Issues #80

Closed skailasa closed 3 years ago

skailasa commented 3 years ago

This addresses #77, which details a number of at the time unknown issues with the accuracy of PyExaFMM. I can report that there were 3 main issues, which are addressed in this PR.

1) Calculation of the pseudoinverse of highly ill conditioned matrix 2) Random BS bugs (casting contribution from W List to int rather than float, thus rounding it to 0) 3) A catastrophic bug in the calculation of the V List for leaf nodes not discretised to maximum level, which was fixed here