excaliburpartners / OmniLinkBridge

MQTT bridge, web service API, time sync, and logging for HAI/Leviton OmniPro II controllers
GNU General Public License v3.0
41 stars 24 forks source link

MQTT "hold_" topics are being deprecated #43

Closed eddyg closed 2 years ago

eddyg commented 2 years ago

I'm receiving these deprecation warnings, and I think they're coming from the (awesome!) OminLinkBridge:

The 'hold_command_topic' option is deprecated, please remove it from your configuration
The 'hold_state_topic' option is deprecated, please remove it from your configuration
The 'hold_modes' option is deprecated, please remove it from your configuration

My understanding is that preset_modes and topics now replace the hold modes, so hold is just another preset_mode now?

https://github.com/home-assistant/core/blob/dev/homeassistant/components/mqtt/climate.py#L813-L822

Just wanted to bring this up in hopes of getting it addressed before the deprecation deadline.

Thanks for the great integration!

rwagoner commented 2 years ago

Thanks for the heads up! I've made this change on the dev branch and will include it in the next release.