exelban / stats

macOS system monitor in your menu bar
MIT License
26.35k stars 869 forks source link

Stats 2.4.0 crashes after each app restart #136

Closed jgoldhammer closed 4 years ago

jgoldhammer commented 4 years ago

Stats 2.4.0 crashes for me. After a restart, stats crashes every time. I have attached a crash report...

Stats_2020-11-02-084010.txt

exelban commented 4 years ago

Hi.

Thanks for reporting. Could you try this version? Could you also provide your mac specs? Because it looks like some memory bug.

Stats.dmg.zip

Coliinnn commented 4 years ago

I can confirm this has happened to me as well since updating to 2.4.0 yesterday. These are the specs of my mac. The crash still happens with the DMG you just provided on my Mac. Stats_2020-11-02-095250.txt

exelban commented 4 years ago

Thanks. Could you try this one?

Stats.dmg.zip

Coliinnn commented 4 years ago

So far this seems to work. I have it running about ten minutes without a crash, which seems promising

exelban commented 4 years ago

It crushes only on start. So, if the app starts it will work normally.

Unfortunately, I don't fix a problem with this build. I only remove the problem place. I cannot reproduce the problem on my computers. Could maybe someone check a few more builds? To ensure that problem is fixed.

exelban commented 4 years ago

Stats.dmg.zip

Coliinnn commented 4 years ago

This build looks good too on my end

exelban commented 4 years ago

@Coliinnn thanks. Could you check the sensors and fans? If the widgets show correctly. Because the problem was in these widgets.

Coliinnn commented 4 years ago

I just came back to my computer and it did crash in this latest build. I was already using the fans widget, not the sensors one. The fans widget was showing correctly at least, but it did result in a crash seemingly. Is there a specific sensor to test or can I try any? Stats_2020-11-02-105053.txt

exelban commented 4 years ago

Nope. If it crash, it will crash. The widget is the same in sensors and fans modules. Application crashes when trying to calculate what width of widget must be.

exelban commented 4 years ago

Build nr.1: Stats.dmg.zip Build nr.2: Stats.dmg.zip

exelban commented 4 years ago

Don't post a crash report. It has the same bug and the same info.

Coliinnn commented 4 years ago

Ok, I didn't know. So the issue is not even part of the fans or sensors themselves. Build nr.1 crashed for me, as did build nr.2

exelban commented 4 years ago

Stats.dmg.zip

wfrank21 commented 4 years ago

Crashes for me as well. (all builds mentioned here)

Coliinnn commented 4 years ago

Yep, even this last one from four minutes ago

exelban commented 4 years ago

Stats.dmg.zip

wfrank21 commented 4 years ago

Crashes

exelban commented 4 years ago

Stats.dmg.zip

Coliinnn commented 4 years ago

This too crashes

exelban commented 4 years ago

Stats.dmg.zip

exelban commented 4 years ago

Sorry for the long responses. But I must wait till Apple validates and sign a new build.

Coliinnn commented 4 years ago

That's ok. I (and others too I'm sure) already appreciate your responsiveness and attempts at fixing this. I see the last build has changed the fan module display; from two to one row (on automatic setting). So far no crash yet and I restarted it three times to test.

wfrank21 commented 4 years ago

Works for me too! Donation will be made! Thanks alot!

exelban commented 4 years ago

Stats.dmg.zip

wfrank21 commented 4 years ago

In this one only the left fan shows up (in half size) and crashes after around 30sec-1min.

exelban commented 4 years ago

Hmm, could you send a crash report?

wfrank21 commented 4 years ago

Stats_2020-11-02-133247.txt

exelban commented 4 years ago

Does the last build works?

wfrank21 commented 4 years ago

The one from 2 hours ago works. This one only shows one fan (left) but in normal size.

exelban commented 4 years ago

Oh, I know that some version works. Could you try the last one and say if it works or crashes?

wfrank21 commented 4 years ago

Last one (13:29, CET) crashes. Log from 13:38 CET relates to the last one.

exelban commented 4 years ago

Stats.dmg.zip

wfrank21 commented 4 years ago

14:26 CET crashes as well.

exelban commented 4 years ago

Thanks for helping. I have a few macs where I can test an app. But on all it works fine. So I'm trying to fix the problem. But I cannot reproduce it( So the only option is someone who has crashing the app, will check if it still crashes.

Stats.dmg.zip

wfrank21 commented 4 years ago

14:49 CET seems to work fine. But now no Sensors or Fanspeeds show up. Bildschirmfoto 2020-11-02 um 14 56 02 Bildschirmfoto 2020-11-02 um 14 55 56

exelban commented 4 years ago

Yeap, I know exactly where is the problem. I just don't know how to fix it. App crash because it tries to access the variable which is free. But it doesn't use pointers in this part of the app. And it makes a problem to fix it.

Coliinnn commented 4 years ago

That's weird. The build from a few minutes ago runs fine for me, no crash. One row fans displays them next to each other

exelban commented 4 years ago

Yeap, it's if you have switched to One row. The problem appears only when it tries to draw 2 rows. Stats.dmg.zip

exelban commented 4 years ago

Build nr.2: Stats.dmg.zip

Tell please if some of these not crash.

wfrank21 commented 4 years ago

Build from 15:14 CET does not crash, but only shows fan speeds in one row mode. Build from 15:20 CET crashes with two rows.

Coliinnn commented 4 years ago

Nr1 didn't crash but also did not draw two rows. Nr2 crashed with two rows. I see wfrank has the same just now

exelban commented 4 years ago

Thanks. What about this one? Stats.dmg.zip

Coliinnn commented 4 years ago

This crashed for me

exelban commented 4 years ago

Fck, I can't understand why it releasing the objects. Could you maybe disable the Fans module and check if it changes something?

wfrank21 commented 4 years ago

Crashed for me as well. Trying now without Fans Module

exelban commented 4 years ago

Stats.dmg.zip

wfrank21 commented 4 years ago

15:41 CET works without Fans Module. Trying 16:04 CET now

exelban commented 4 years ago

Really? The app which crashes works if the Fans module is disabled? It can change a lot)

wfrank21 commented 4 years ago

Correct.