exelban / stats

macOS system monitor in your menu bar
MIT License
26.39k stars 871 forks source link

Stats 2.4.0 crashes after each app restart #136

Closed jgoldhammer closed 4 years ago

jgoldhammer commented 4 years ago

Stats 2.4.0 crashes for me. After a restart, stats crashes every time. I have attached a crash report...

Stats_2020-11-02-084010.txt

wfrank21 commented 4 years ago

16:04 CET seems to work fine, but only one row mode works

exelban commented 4 years ago

Could you try this one with the disabled Fans module and enabled Sensors? Stats.dmg.zip

Coliinnn commented 4 years ago

16:04 when the fans module is enabled it shows just an empty space in the menubar for two row. Screenshot 2020-11-02 at 16 11 53. No crash though. Single row displays it the right way

exelban commented 4 years ago

[16:04] This version works because it has disabled rendering the 2 rows.

entee55 commented 4 years ago

16:04 CET works for me but no sensor readings. It only shows blank

exelban commented 4 years ago

Yeap, it works and shows blank because it has disabled rendering (which is the crashing reason).

exelban commented 4 years ago

Stats.dmg.zip

Coliinnn commented 4 years ago

16:17 with fans disabled and two-row sensor heatpipe readings enabled does not crash for me it seems. Update: I think it did crash after a while

exelban commented 4 years ago

Ok, it looks like we need to select some testing method. Could you please turn on the Sensors and Fans module?

Stats.dmg.zip

Coliinnn commented 4 years ago

16:36 crashed when I had both sensors and fans double row. But the previous build from 16:17 also crashed after a while with two row sensors, no fans.

entee55 commented 4 years ago

16:36 same for me. Crashed if sensors and fan enabled with 2 row.

exelban commented 4 years ago

Ok, I revert the changes of this widget. Could you test it? Stats.dmg.zip

Coliinnn commented 4 years ago

16:49 crash with both two-row sensor and fans. Two-row sensors (no fans) crashed, two-row fans crashed too. :(

entee55 commented 4 years ago

seems goods far. no crash for 4 minutes. Fan and sensors enabled. 2row option is not there, but working as expected.I only have one fan, so maybe that's the key point for the crash.

exelban commented 4 years ago

@Coliinnn Ok, so it looks like the Fans module is not causing the problem. The problem is with the widget itself. @entee55 the last version works fine for you? No crashes?

entee55 commented 4 years ago

yes no crashes yet. for 10 minutes

Coliinnn commented 4 years ago

@entee55 do you have two-row sensors or one? And sometimes when it doesn't crash for me, when I click on the module it then crashes still. @exelban yes it seems like it, it happens on both modules

entee55 commented 4 years ago

2 row sensors, I clicked on it and no crash. But the 2 row sensors is now automatic, no option to select 2 row

entee55 commented 4 years ago

oh, it just crashed after 12 minutes

exelban commented 4 years ago

Stats.dmg.zip

entee55 commented 4 years ago

should it remember my earlier settings? every new file you send have sensors and fan set on, like before removing the older version

exelban commented 4 years ago

Better to have Sensors and Fans modules on

entee55 commented 4 years ago

yeah sure. I was only asking because I read earlier that by default both are off. I thought maybe it was important.

exelban commented 4 years ago

It disabled by default. But it causes crashing. So it must be turned on.

exelban commented 4 years ago

What about the last build?

entee55 commented 4 years ago

no crashes so far. Running for 8 minutes. I tried to click every module, no crash yet.

exelban commented 4 years ago

Ok. Thanks. Could you try this one? Stats.dmg.zip

exelban commented 4 years ago

If the app not crashing on launch, it will not crash with time. It can crash with time only in these builds because I just try to prevent crashing.

entee55 commented 4 years ago

no crash. 2 row option is back

entee55 commented 4 years ago

it crashed after 3 minutes

exelban commented 4 years ago

Nice, nice. What about this one? Could you send a crash report?

Stats.dmg.zip

Coliinnn commented 4 years ago

17:15 you can see the 'RPM' text does not fully render, it only shows part of the R. Screenshot 2020-11-02 at 17 29 43 But no crash at start

Coliinnn commented 4 years ago

17:31 The RPM text renders fully again, no crash at start yet. Both modules turned on with two-row. I will let it run for a bit

entee55 commented 4 years ago

17:31 same for me

entee55 commented 4 years ago

it just crashed

entee55 commented 4 years ago

sorry, I do not know how to send a crash report

exelban commented 4 years ago

No problem. In the Utilities folder find an app called Console. Open it and you will see in the left part tab called Reports. There you can find all reports of crashed apps. Or you can do it with a spotlight, just search console.app.

Could you check this one? Stats.dmg.zip

entee55 commented 4 years ago

earlier crash report. now testing the new Crash report 1735.txt

entee55 commented 4 years ago

latest crash report Crash report 1756.txt

exelban commented 4 years ago

Don't post a crash report every time. It will be the same) So, it not crash at the start. But with some time?

Coliinnn commented 4 years ago

The 17:31 did not end up crashing for me. 17:44 crashed after 1-2 minutes. Not immediately at the start. No crash report needed this time?

exelban commented 4 years ago

Nope. Thanks.

entee55 commented 4 years ago

it crashed about after half a minute

exelban commented 4 years ago

Ok. What about this one? I hope it will work without crashes. But yeap, the width of the widget (sensors and fans) will be strange.

Stats.dmg.zip

entee55 commented 4 years ago

no crash at start. crashed after 2 minutes. fan rendering failure: only shows first 2.5 characters of actual speed

Képernyőfotó 2020-11-02 - 18 09 20
Coliinnn commented 4 years ago

Three minutes, no crash yet

exelban commented 4 years ago

Stats.dmg.zip

entee55 commented 4 years ago

crash at start. rendering was OK though actually crash was at first click second run: crashed without click after 10 sec.

exelban commented 4 years ago

I just cannot understand what happens. How it possible that the app crashing after some time( It just update the value, but in some moment crashing with the reason that some sensor is no allocated(

Coliinnn commented 4 years ago

No crash at start for me actually, also not when clicking it. Took about 50 seconds, then crashed