exelban / stats

macOS system monitor in your menu bar
MIT License
26.41k stars 871 forks source link

Stats 2.4.0 crashes after each app restart #136

Closed jgoldhammer closed 4 years ago

jgoldhammer commented 4 years ago

Stats 2.4.0 crashes for me. After a restart, stats crashes every time. I have attached a crash report...

Stats_2020-11-02-084010.txt

Coliinnn commented 4 years ago

Yeah it's super weird!

exelban commented 4 years ago

There is no much information about this type of bug. But if I understand correctly it's a problem with gc. And it happens only in the release build. Because it tries to be smart. And it looks like it frees a sensor when iterating the list.

exelban commented 4 years ago

Stats.dmg.zip

entee55 commented 4 years ago

No crash at start. Fan section not visible, just a few pixel wich is clickable

exelban commented 4 years ago

Yeap, it's ok. The main goal is to prevent crashing)

entee55 commented 4 years ago

still running

exelban commented 4 years ago

Hmm. Nice, nice. I hope it will work. I will build the version with a normal widget size. If there will be no crashes, it will be the last one.

Coliinnn commented 4 years ago

Seems to run OK here as well. Let's hope!

exelban commented 4 years ago

Stats.dmg.zip

Coliinnn commented 4 years ago

Ah shit, just as I commented that - it crashed.

exelban commented 4 years ago

Ok, check please if this one does not crash at the start.

exelban commented 4 years ago

If yes, please post a crash report.

Coliinnn commented 4 years ago

Crashed after 1-2 minutes. That was with sensors and fan, both two-row Stats_2020-11-02-184805.txt

exelban commented 4 years ago

Ok, I will try the another way to update the values.

entee55 commented 4 years ago

I did not checked the new one but the one before that is still running. Should I check the new one?

exelban commented 4 years ago

Nope, thanks. Could you try this one? I know that it can be some bugs. But for now only crash interest me)

Stats.dmg.zip

Coliinnn commented 4 years ago

Crashed for me after a few minutes

exelban commented 4 years ago

@Coliinnn The last one (7min ago) or the previous one?

Coliinnn commented 4 years ago

The last one!

entee55 commented 4 years ago

last one crashed after about 5 minutes

exelban commented 4 years ago

Ok, I don't see another option for now. I will disable 2 rows option and deploy a new version. The fans and sensors will be visualized in widget only in one row. And I hope someone will help me to make it work till the next release. Could you check if this one is not crashing after some time?

Stats.dmg.zip

exelban commented 4 years ago

I will not close this issue. I will just release a new version to ensure that users will have a working app. I still will need help from someone to test a new builds.

Coliinnn commented 4 years ago

Yeah I think that's the way to go. Unfortunately it seems like a persistent issue, but this workaround seems good for now. Let's hope someone will be able to help out. I'll update this comment with results from the latest version. Update: still works fine after 7 minutes, I think it's good

entee55 commented 4 years ago

okay, I kept the one working without fan display. I do not need fan readout.

wfrank21 commented 4 years ago
Bildschirmfoto 2020-11-02 um 19 41 53

Somehow now Fanspeed is not showing up after some time with the 19:34 release.

entee55 commented 4 years ago

You should keep the sensor double row but not the fan . I think that worked that way.

wfrank21 commented 4 years ago

There is no option for one row in the 19:34 release, only on or off.

entee55 commented 4 years ago

these test releases were not for use. many of them are wrongly displayed for testing. read back each release was tested by us only for crash.

exelban commented 4 years ago

@entee55 yeap. I agree with you. I will keep 2 rows and disable the Fans module (till I will make some fix for this). Stats.dmg.zip

exelban commented 4 years ago

I will ask someone to help me with testing this. Because I still cannot reproduce this bug. It looks like it related to some specs. Maybe the number of sensors. Maybe to the ram.

wfrank21 commented 4 years ago

Do you need our specs?

entee55 commented 4 years ago

We really appreciate your fast response and all of the work so far. :)

exelban commented 4 years ago

@wfrank21 It will not help(

exelban commented 4 years ago

Or maybe. @entee55 @wfrank21 @Coliinnn could you post the model of your macs? Maybe you have the same.

wfrank21 commented 4 years ago
image

Is this enough?

exelban commented 4 years ago

@wfrank21 yeap. Thanks. So you have a different macs.

entee55 commented 4 years ago
entee55 mac
exelban commented 4 years ago

Could someone run this one and post a crash report if t will crash?

Stats.dmg.zip

entee55 commented 4 years ago

running since you posted

exelban commented 4 years ago

@entee55 does it works with the Fans and Sensors module enabled? Does it shows the values in the 2 rows layout?

entee55 commented 4 years ago

It does not show fans. not even in the menu. Sensors work with 2 row.

stats_2 4 1 final
exelban commented 4 years ago

Hmm. Interesting. Check please this one. It has totally disabled the Fans module. But it has a new Sensors widget.

Stats.dmg.zip

entee55 commented 4 years ago

seems good. no crash after 5 min. Still no fans in menu (just feedback no complain).

entee55 commented 4 years ago

it crashed after 6 minutes the one before never crashed (about 30 min)

exelban commented 4 years ago

Could you post the crash report? And if you can, please run the previous version. To be sure that the previous one is not crashing.

entee55 commented 4 years ago

stats 2.4.1 no fans in menu_crash report.txt

entee55 commented 4 years ago

I will be off for maybe a few hour so it will be running.

exelban commented 4 years ago

Thanks, run please this one. It's similar to the build from 30min before but has enabled the Fans module. Stats.dmg.zip

entee55 commented 4 years ago

just started running. no crash so far for 4 minutes. running it with 2x2row sensor and 2 row fans in settings (shows same in menu bar as single row option) no crash at clicks either

entee55 commented 4 years ago

Crashed after 6 minutes. stats 2.4.1 no 2100_crash report.txt second run crashed after 20 seconds