Closed irene-mandarine closed 6 months ago
Hello. Thanks for opening an issue on Exercism 🙂
At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.
If you're interested in learning more about this auto-responder, please read this blog post.
There is a small gap in test cases which would allow error prone code to pass the tests. For example, there is checked 32 with empty list as the result (because it's 10_000 in binary), and it works fine for following code (returns empty list on after index == 4 check) : ` fun calculateHandshake(number: Int): List {
val action = Integer.toBinaryString(number).reversed()
val result = mutableListOf()
Once you change test number to 33, which also should return an empty list, the list actually contains "WINK"
I propose to add one more test case to cover that little gap