search

exercism / v3-beta

12 stars 2 forks source link

Note blocks shouldn't be rendered using pre #307

Closed glennj closed 3 years ago

glennj commented 3 years ago

I see this at https://exercism.lol/docs/community/being-a-good-community-member/the-words-that-we-use: image

Clearly, having to scroll horizontally is not optimal.

iHiD commented 3 years ago

@glennj Thanks. This is a rendering issue in v3 so I've moved it here.

@ErikSchierboom I don't think we added these and some exercises (and this doc) rely on them :S

As a reminder, these are code-fences with the language set to note or some others that will be in the spec. Could you mutate these to be <div class="c-textblock-note"> or c-text-warning etc pls. I'll then add styling.

@bethanyG I think you used these in exercises? Got an example of where one is that I can use to test things pls?

ErikSchierboom commented 3 years ago

@iHiD I don't see note being used in Python if I'm looking correctly. I do see Julia using ~~~~exercism/note. Should we support both note and exercism/note?

iHiD commented 3 years ago

Oooh, good point. No, I believe we changed the spec to exercism/note, didn't we. So we should use that instead.

iHiD commented 3 years ago

(and update note to exercism/note anywhere it appears in the docs)

ErikSchierboom commented 3 years ago

Sure. Will do

ErikSchierboom commented 3 years ago

@iHiD PR has been updated

ErikSchierboom commented 3 years ago

And a docs PR has also been created.

glennj commented 3 years ago

Fix is reflected in https://exercism.org/docs/community/being-a-good-community-member/the-words-that-we-use

Thanks to all!