[FEATURE] Added scraper to add all translations to the database.

experius / Magento-2-Module-Experius-MissingTranslations

Collect missing translations in specified folder or the entire Magento 2 Root

Open Software License 3.0

52 stars 13 forks source link

[FEATURE] Added scraper to add all translations to the database. #1

Closed borisvankatwijk closed 6 years ago

borisvankatwijk commented 6 years ago

This makes it possible for merchant/clients to translate any string in the adminpanel of Magento.

Added Console command to scrape all translations --Option of including missing translation files if they are gathered (if file exists)
Added crontab to insert new translations nightly at 3:13 AM (i.e. if new module is installed or translatable strings changed)
Minor UX / syntax improvements in loose commits

borisvankatwijk commented 6 years ago

EDIT: Added to readme. Missing features (to-do's next release)

Add flag to translation database; if user edit's a translation, user_defined is flagged as true.
Add --force update for every entry that is not flagged as user_defined; to update csv changes into database.

borisvankatwijk commented 6 years ago

FIXED ui component -> bookmarks FIXED no inline delete but inline edit REMOVED (redundant) shortkey for include is not working (but can be solved by splitting the command) ADDED has a translation doesn't get updated after save ADDED has a translation doesn't get set to the right value when updating module in existing envirnoment ADDED split the cron to two crons for existing and missing translations ADDED split the console command to two commands for existing and missing translations TODO add configuration to by default disable the cron for existing ones because the main feature is missing translations

@lewisvoncken , How do you propose to disable the cron be default? Is this simply a parameter one can give with the crontab xml?

borisvankatwijk commented 6 years ago

Added latest bugfix, which prevents admin from changing locale on save.

lewisvoncken commented 6 years ago

@borisvankatwijk as an answer on your question: How do you propose to disable the cron be default? Is this simply a parameter one can give with the crontab xml?

I recommend to just add an enabled check in the cron collect class

https://github.com/experius/Magento-2-Module-Experius-MissingTranslations/blob/feature-database/Cron/Collect.php

borisvankatwijk commented 6 years ago

Good point, will look into it. Thought maybe there was a xml setting instead of adding a system.xml config. To be continue'd =D