expressodev / twitter_search

Twitter Search 2 plugin for ExpressionEngine 2.x
15 stars 2 forks source link

Link parsing and link to tweet id #1

Closed jannisg closed 13 years ago

jannisg commented 13 years ago

Hello!

First of all, great plugin!

Using it at the moment however I noticed a few oddities that I thought I'd mention here:

  1. When my tweet contains a URL such as "themixtapeclub.org" the parsed output does not wrap this in a link tag (presumably since it does not have a http: protocol mentioned anywhere). I think the official twitter client doesn't do this either but it would be nice if you could add this in.
  2. I would like to link the {relative_date} timestamp to the specific tweet url (eg: twitter.com/username/status/id). I've tried the available tags but cannot seem to get the unique tweet id from them. Am I missing something/doing something wrong or can this not currently be done?

Again, great plugin.

Cheers, Jannis

amacneil commented 13 years ago

Hi Jannis

For your first issue - I doubt this will change any time soon. We just use a standard EE library to create the links, so it's really up to that library to detect incomplete urls such as example.com. It's really beyond the scope of this simple plugin to handle link parsing like that - you could try requesting EllisLab add it, or look for a specific better link parsing plugin maybe.

For the second issue - I've just published a new version with a {tweet_url} variable to help you do that. You also should have been able to create the link yourself using the {id} variable, but there was a small bug causing it to display in scientific form. Fixed now!

Cheers Adrian

jannisg commented 13 years ago

Excellent, thanks! Apologies for the late response.