search

eyeonus / EDDBlink

(No longer maintained) A plugin for TradeDangerous to update market data using EDDB's api files.
GNU Lesser General Public License v3.0
2 stars 0 forks source link

Changed printed progres messages to use the progress bar from tradeda… #6

Closed MarkAusten closed 6 years ago

MarkAusten commented 6 years ago

As requested I have submitted my code as a pull request. This uses the progress bar from tradedangerous (misc.progress) and replaces the printed progress messages. The width has been set to 100 characters so that the updates are at 1% intervals.

eyeonus commented 6 years ago

Okay, I like it, but two things:

remove the "import urllib" line, it's not needed.

Don't remove the old method, Do an if else so that I can put in code to do either one by passing an option.

It can even be

if True:
    pbar
else:
    text
MarkAusten commented 6 years ago

I've made the changes as requested.

There is an argument that says the original string message should be moved into the progress class. I'd be tempted to do that myself, feels cleaner.

eyeonus commented 6 years ago

Cool, now all I have to do is add the option code, which is a simple matter.

Ah, no, I also have to add an "if" around the clear statements as well.

You almost got me, but I saw it in time! :P