eyre-rs / eyre

A trait object based error handling type for easy idiomatic error handling and reporting in Rust applications
Apache License 2.0
1.41k stars 66 forks source link

Fix MSRV CI #102

Closed yaahc closed 1 year ago

yaahc commented 1 year ago

The CI is failing due to the 1.42 version subset of the test matrix.

https://github.com/eyre-rs/eyre/blob/master/.github/workflows/ci.yml#L69

The reason it is failing seems to be due to thiserror requiring the edition = 2021. We use thiserror in tests and documentation. I see a couple of potential directions we could go in resolving this issue:

I think I lean toward the first option. I cannot anticipate any situations where we'd see breakage in runtime behavior exercised by tests across versions that we wouldn't catch due to this change. If we build in the old version and tests pass in the current version, we're almost certainly fine.

pksunkara commented 1 year ago

@ten3roberts Can this be closed with your recent MSRV changes?