search

eyre-rs / eyre

A trait object based error handling type for easy idiomatic error handling and reporting in Rust applications
Apache License 2.0
1.41k stars 68 forks source link

PyO3 integration - offer to rehome #57

Closed davidhewitt closed 11 months ago

davidhewitt commented 3 years ago

Hi,

Thanks for providing integration with PyO3!

Over in the PyO3 repo we're currently discussing accepting an anyhow optional feature. https://github.com/PyO3/pyo3/pull/1822

I am aware that you've got the pyo3 optional feature; I was wondering if for symmetry you wanted us to take ownership of the eyre / pyo3 integration by adding an eyre optional feature to pyo3?

Presumably we can just copy the trait implementations you already have from this repo over to the PyO3 codebase.

yaahc commented 3 years ago

I was wondering if for symmetry you wanted us to take ownership of the eyre / pyo3 integration by adding an eyre optional feature to pyo3?

Sure!

davidhewitt commented 3 years ago

@yaahc we've now merged an eyre feature into PyO3 and will probably release it in the next couple of weeks (https://github.com/PyO3/pyo3/issues/1921). Feel free to close this ticket / update eyre as you see fit.