search

ezra-bible-app / node-sword-interface

JavaScript (N-API) interface to SWORD library
GNU General Public License v2.0
22 stars 2 forks source link

getStrongsEntry returns empty object on Android #19

Closed zhuiks closed 3 years ago

zhuiks commented 3 years ago

While working on showing dictionary info on long press and testing it on Android, I found that ipcNsi.getStrongsEntry(normalizedKey) returns an empty object in dictionary_controller.js#143 https://github.com/ezra-project/ezra-project/commit/33018aa6f570d73aa642d987cd11b257a7f90176

Empty object will cause other errors.

In Electron everything works fine

tobias-klein commented 3 years ago

Thanks for reporting this. Note that this is likely due to differences in the IPC communication and therefore probably not an issue in node-sword-interface, but rather how it is wrapped in the Cordova context.

tobias-klein commented 3 years ago

There is not much special about the method getStrongsEntry. How did you test this? In the Android emulator? Are the Strong's modules installed? That's the requirement for this to work.

zhuiks commented 3 years ago

Yes, it was on Emulator. Let me double-check about Strong's modules.

tobias-klein commented 3 years ago

Does the module assistant still automatically install the Strong's modules if a Bible translation has that feature? If not then that could be the root cause for this behavior.

zhuiks commented 3 years ago

I'm confirming that this is related to not having Strong's modules installed. I created an issue: https://github.com/ezra-bible-app/ezra-bible-app/issues/404