search

ezranbayantemur / react-native-rtmp-publisher

📹 Live stream RTMP Publisher for React Native
MIT License
98 stars 14 forks source link

Update ios 1.4.2 #34

Closed turkmenkaan closed 1 year ago

turkmenkaan commented 1 year ago

This seems to work fine on my machine, can we get this merged?

ezranbayantemur commented 1 year ago

It's not passing the pipeline. build_ios step is crashing. It may works on your machine but it should work on every machine, not just yours.

Plus, you just commented out some of the source code. It's an anti-pattern method and code-comments are not allowed to the codebase. I can't accept them like that.

Please update your code and open a PR again.