ezrpg-legacy / ezRPG-1.2.x

ezrpgproject.net
8 stars 7 forks source link

Let's stop using PHP sessions #54

Closed JakeBooher closed 7 years ago

JakeBooher commented 7 years ago

Let's create our own internal session system.

deohnas commented 7 years ago

Could you elaborate on what you want to do, are we talking about an different API , like a Session class. Or do you mean how we store the session data?

uaktags commented 7 years ago

Maybe come back to this after 1.3, unless there's a glaring need, it's probably less necessary in our current state.

JakeBooher commented 7 years ago

Doing something like this would be fairly important. Right now using PHP sessions it is impossible to have a "keep me logged in" button, as the cookie created for these only last until the browser is closed.

uaktags commented 7 years ago

That sounds a bit different of a need then "let's create our own internal session system". I'd still rate that issue to be less of a problem and more of a nuisance and probably be easily fixable within a hook and the login module. But otherwise a full rework of session handling should still probably be pushed off until atleast we clean up the code, fix the more glaring issues, etc.

deohnas commented 7 years ago

I agree with @uaktags

uaktags commented 7 years ago

Closing for now, we can come back to it later if the need arises.