search

f1u77y / wmc-mpris

MPRIS proxy for usage with Web Media Controller on GNU/Linux
The Unlicense
25 stars 1 forks source link

Add alternative installation instructions #3

Closed doronbehar closed 5 years ago

doronbehar commented 5 years ago

Move extension installation instruction and explanation to the top. Better phrase the usage opening paragraph.

f1u77y commented 5 years ago

Thanks! I think it's still better to install to $HOME via cmake and make, so I've pushed corresponding changes. Please replace your alternative installation instructions with just:

$ cmake -DINSTALL_FOR_CURRENT_USER=On ..
$ make install

This pattern is very rare on GNU/Linux system though.

In addition to installing/building the web-media-controller, you will need to install [this browser extension]

The browser extension itself is called web-media-controller, so please refer to the program in this repo in other way, eg. "wmc-mpris".

While it is running, and the extension installed

I think this phasing could mislead user into thinking that they should run this program manually (while they shouldn't). I'd suggest something like "while both this program and extension are installed".

Your changes seem fine in other ways, so I'll accept them, thanks again for your contribution.