Enable setting browser manifests install location

f1u77y / wmc-mpris

MPRIS proxy for usage with Web Media Controller on GNU/Linux

The Unlicense

25 stars 1 forks source link

Enable setting browser manifests install location #5

Closed doronbehar closed 5 years ago

doronbehar commented 5 years ago

I'm trying to package wmc-mpris in NixOS. We are having trouble with the hardcoded /etc/chromium and other locations written in CMakeLists.txt. This Change enables us to elegantly use our own prefix and having the native-messaging-hosts json files point to the right location of the executables.

I don't think it affects the current behaviour. If you are willing to merge this, I'll add a commit that updates the README accordingly.

Thanks.

f1u77y commented 5 years ago

It seems fine but then info here and there is not correct for this distribution. I know what is NixOS but I don't think changing documented paths is a good idea.

worldofpeace commented 5 years ago

We're actually not going to change the documented paths, it's just everything in NixOS is installed to its own separate prefix within /nix/store. NixOS provides an interface to link files that programs expect to be at etc with environment.etc.source = _path_to_file.

doronbehar commented 5 years ago

@f1u77y would you request a README PR for documenting these new options?