fabianmichael / kirby-markdown-field

Super-sophisticated markdown editor for Kirby 3, community built.
Other
160 stars 14 forks source link

The plugin doesn't work in Kirby 3.4.4 #103

Closed krisjfr closed 3 years ago

krisjfr commented 4 years ago

Nothing change with "type: markdown" instead of "type: textarea"

eXpl0it3r commented 3 years ago

Works "fine" for me on Kirby 3.4.4, i.e. when I set type: markdown I get a markdown editor

krisjfr commented 3 years ago

Thanks for answering. I’ve tried again. The only change I see while “type: markdown” is set... is a different font. But no new buttons from Mardown Fields plugin. Where can it come from then? What do I miss ?

On 7 Nov 2020, at 11:14, Lukas Dürrenberger notifications@github.com wrote:

Works "fine" for me on Kirby 3.4.4, i.e. when I set type: markdown I get a markdown editor

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

eXpl0it3r commented 3 years ago

The plugin is using the same toolbar as the textarea, as such it might look the same at a first glance. See the readme on how to configure buttons.

krisjfr commented 3 years ago

Hi, are you saying that the out-of-box settings for “Markdown field” plugin may not be not different from the default blueprint "type: textarea” layout ? if yes, why not to precise it on github ?

(I’ve used the .zip version => download => unpack)

On 7 Nov 2020, at 14:35, Lukas Dürrenberger notifications@github.com wrote:

The plugin is using the same toolbar as the textarea, as such it might look the same at a first glance. See the readme on how to configure buttons.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

eXpl0it3r commented 3 years ago

What I'm saying is, that if you just superficially look at the panel field, they'll look very similar, since they both use the same toolbar icons. But once you start adding text and start formatting it, you'll notice that the markdown field will format it differently.

krisjfr commented 3 years ago

Nope. As I‘ve said, the field “type: markdown” is recognized by Kirby, and the font changes (ugly). But there is no new markdown options availables in formatting bar whatever I do. I did test it on “Kirby starter” (so without my multilingual settings). Idem. I’ve tried “Editor” and "enhanced-toolbar-link-dialog” plugins. They work “out-of-box” (zip versions). What’s wrong (with me) ? :-(

On 20 Nov 2020, at 09:27, Lukas Dürrenberger notifications@github.com wrote:

What I'm saying is, that if you just superficially look at the panel field, they'll look very similar, since they both use the same toolbar icons. But once you start adding text and start formatting it, you'll notice that the markdown field will format it differently.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

eXpl0it3r commented 3 years ago

But there is no new markdown options availables in formatting bar whatever I do.

What would you expect to show up?

Here's an example I used in my blueprint:

            fields:
              content:
                label: Content
                type: markdown
                buttons:
                  - headlines
                    - h1
                    - h2
                    - h3
                    - h4
                    - h5
                    - h6
                  - bold
                  - italic
                  - strikethrough
                  - ul
                  - ol
                  - link
                  - email
                  - image
                  - file
                  - pagelink
                  - blockquote
                  - horizontal-rule
krisjfr commented 3 years ago

My God. You guess I did expect these options visible without doing anything but changing the field type to markdown. Thank you for your patience, Lucas. This topic is closed.

On 22 Nov 2020, at 02:01, Lukas Dürrenberger notifications@github.com wrote:

But there is no new markdown options availables in formatting bar whatever I do.

What would you expect to show up?

Here's an example I used in my blueprint:

        fields

:

content :

label: Content

type: markdown

buttons :

  • headlines

                - 

    h1

                - 

    h2

                - 

    h3

                - 

    h4

                - 

    h5

                - 

    h6

  • bold

  • italic

  • strikethrough

  • ul

  • ol

  • link

  • email

  • image

  • file

  • pagelink

  • blockquote

  • horizontal-rule — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.