search

fabianmichael / kirby-markdown-field

Super-sophisticated markdown editor for Kirby 3, community built.
Other
160 stars 14 forks source link

`font: sans-serif` not working (Invalid value) #126

Closed pReya closed 2 years ago

pReya commented 2 years ago

I just wanted to try out the sans-serif font option, however it is not working for me:

This is my blueprint:

title: Default Page
preset: page
fields:
  text:
    label: Text
    type: markdown
    size: large
    font: sans-serif
    buttons:
     - bold

When I open the panel, I am greeted with this:

Error in "text" field.

Invalid value for "font" in file: /Users/moritz/Code/fabcity-wiki-kirby/kirby/src/Toolkit/Component.php line: 187
fabianmichael commented 2 years ago

@pReya Which version did you use? 1.x or 2.0 beta (aka ‘next’)? Please note, that the new version can only be installed by downloading the next branch or by using it as a git submodule at the moment.

https://github.com/fabianmichael/kirby-markdown-field/tree/next

pReya commented 2 years ago

I did read that. However I did not remember that the git link does not include the currently selected branch. So I still needed to check out the correct branch. Thanks!

felixfischer commented 2 years ago

I ran into the same problem, but I would like to stick to the composer installation method. Is the next major release planned for the foreseeable future?

fabianmichael commented 2 years ago

I ran into the same problem, but I would like to stick to the composer installation method. Is the next major release planned for the foreseeable future?

The main problem is, that CodeMirror is still in beta and sometimes has breaking changes, so I’m hesitating to release this as final until CM 6.0 is.

@pReya @felixfischer You can tell composer to install a branch instead of the last stable release: https://getcomposer.org/doc/articles/versions.md#branches

felixfischer commented 2 years ago

Thanks for the tip - that helped!