fabianmichael / kirby-markdown-field

Super-sophisticated markdown editor for Kirby 3, community built.
Other
160 stars 14 forks source link

Style adjustments #145

Closed medienbaecker closed 2 years ago

medienbaecker commented 2 years ago

Related issue: https://github.com/fabianmichael/kirby-markdown-field/issues/143

I'll update this pull request with additional changes. For now I've done the following:

medienbaecker commented 2 years ago

It looks identical to the core textarea now. I noticed the core <textarea> element is inline so it visually has more padding on the bottom. Not sure if this should be replicated at all.

2022-06-08 12-52-19 2022-06-08 12_52_59

fabianmichael commented 2 years ago

It looks identical to the core textarea now. I noticed the core <textarea> element is inline so it visually has more padding on the bottom. Not sure if this should be replicated at all.

Thanks so far. I don’t think that we should replicate the inline display, it just calls for trouble ;-)

medienbaecker commented 2 years ago

Absolutely. I'm just wondering if we need the extra pixels on the bottom.

I'm also not sure if some people will miss the white space in general 🤷‍♂️

fabianmichael commented 2 years ago

@medienbaecker Thanks for your efforts. I found one glitch that affects quotations:

Bildschirmfoto 2022-06-22 um 09 28 17

I must admit, that I preferred the lighter look that we had before, but it probably makes all of our lives much easier, if we try to align the field design with all other Kirby fields. So please go ahead :-)

fabianmichael commented 2 years ago

@medienbaecker At first glance, it also looks good with Kirby 3.7-rc2! :-)

medienbaecker commented 2 years ago

@medienbaecker Thanks for your efforts. I found one glitch that affects quotations

I can reproduce this issue with 2.0.0-rc1 🤔

CleanShot 2022-06-22 at 12 17 16@2x CleanShot 2022-06-22 at 12 17 10@2x

But anyway, I'm not sure what the blockquote should look like. To be honest I almost never use it.

fabianmichael commented 2 years ago

@medienbaecker The blockquote should have be indented, so it stands out from the regular text. This is what it looked like before:

Bildschirmfoto 2022-06-22 um 12 49 11

medienbaecker commented 2 years ago

@fabianmichael I think you broke this when you added the sans-serif optimizations. Now it's fixed for both versions.

CleanShot 2022-06-23 at 14 40 36@2x
fabianmichael commented 2 years ago

@medienbaecker Great! Can we merge now or is anything left to be done?

medienbaecker commented 2 years ago

@fabianmichael I think so. I'm already using this version on a few client's websites and I haven't noticed anything else.

fabianmichael commented 2 years ago

@medienbaecker Let’s give it a chance. Thanks for your support! :-)