search

fabianmichael / kirby-markdown-field

Super-sophisticated markdown editor for Kirby 3, community built.
Other
162 stars 14 forks source link

Add Parcel to `package.json` and create `package-lock.json` #97

Closed mtsknn closed 4 years ago

mtsknn commented 4 years ago

Parcel wasn't included in package.json, so running npm run build resulted in the following error (I don't have Parcel installed globally):

'parcel' is not recognized as an internal or external command,
operable program or batch file.

I added Parcel to devDependencies to fix this. As a bonus, every contributor will be automatically using the same version of Parcel. This can prevent some obscure problems caused by different versions between contributors.

I also created package-lock.json and removed it from .gitignore. It's generally suggested to include the lock file in the git repo (see e.g. https://stackoverflow.com/q/44552348/1079869). Or is there are a specific reason for not including it here?

sylvainjule commented 4 years ago

My mistake for the package-lock.json! I'll merge the PR.