fabiofalci / sconsify

A spotify console application
https://fabiofalci.github.io/sconsify
Apache License 2.0
566 stars 26 forks source link

UI: Track Display #62

Closed brownzach125 closed 8 years ago

brownzach125 commented 8 years ago

Why did you decide to display songs

- ? In spotify it does title then author I think that makes more sense and is the norm. Also why include the index? ( <index>. <author> - <title> ) Are you planning on a feature using the index? Otherwise it just kind of clutters up the view. What do you think? P.S I'm not assuming you don't have your reasons. I was just curious. </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fabiofalci"><img src="https://avatars.githubusercontent.com/u/6767?v=4" />fabiofalci</a> commented <strong> 8 years ago</strong> </div> <div class="markdown-body"> <p>Good question. Maybe we could title then authors. I don't have anything against. About the index, it helps when using <code>gg</code> to jump to a track. However, we could make this configurable. Maybe a configuration to define the title format? Such as:</p> <pre><code>--song-format={title}-{author} --song-format={index}. {author}-{title} --song-format={index}. {author}-{title} {duration} </code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brownzach125"><img src="https://avatars.githubusercontent.com/u/9419429?v=4" />brownzach125</a> commented <strong> 8 years ago</strong> </div> <div class="markdown-body"> <p>I did not know about the <code>gg</code> feature the index makes total sense then. Yeah I'd really prefer the default to be <code>{index}. {title}-{author}</code> That just seems more user friendly. But configuration would be the best solution.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fabiofalci"><img src="https://avatars.githubusercontent.com/u/6767?v=4" />fabiofalci</a> commented <strong> 8 years ago</strong> </div> <div class="markdown-body"> <p>Ok, cool. Let's change to <code>{index}. {title} - {author}</code> as default and the configuration can be done in another step.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fabiofalci"><img src="https://avatars.githubusercontent.com/u/6767?v=4" />fabiofalci</a> commented <strong> 8 years ago</strong> </div> <div class="markdown-body"> <p>Fixed <a href="https://github.com/fabiofalci/sconsify/commit/690418629132d8b34ca19c0a5f7935f1e974c222">https://github.com/fabiofalci/sconsify/commit/690418629132d8b34ca19c0a5f7935f1e974c222</a></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>