fable-compiler / samples-electron

Fable bindings and samples for Github Electron
Apache License 2.0
60 stars 12 forks source link

Fixed Electron types, Paket, fsproj and nuspec #18

Closed mike-morr closed 7 years ago

mike-morr commented 7 years ago

I wanted to take a stab at this. Please review this one carefully, this is my first nuget package.

-- Adds .fsproj file -- Adds .nuspec file -- Fixes Electron types -- I used dotnet new fable to create the project structure so some of these files may not be necessary.

alfonsogarciacaro commented 7 years ago

Wow, 3500 LOC for the .nuspec file :wink: Actually we're using the dotnet SDK to pack the libraries so the .nuspec file is not necessary, you can take a look at Fable.Elmish project file. With that you only need the following to pack & push the package:

cd src
dotnet restore
dotnet pack
dotnet nuget push bin/Debug/Fable.Elmish.0.9.0.nupkg -s nuget.org -k [API_KEY]
mike-morr commented 7 years ago

@alfonsogarciacaro LOL I didn't even look at it. I used a tool called Nuget Package Explorer, apparently it is verbose. I tried dotnet pack first, but it threw an exception related to the Paket targets. I will remove it so you can package it. If you're ok with that.

mike-morr commented 7 years ago

@alfonsogarciacaro I removed the .nuspec, does it look ok other than that?

mike-morr commented 7 years ago

@alfonsogarciacaro @jgrund I also had to add a few members to satisfy the Interface. Forgot to add that in my original post.

mike-morr commented 7 years ago

@alfonsogarciacaro

Here is what I get when I uncomment the listenerCount

image

Here is what I get when I change listeners to take a string:

image

mike-morr commented 7 years ago

@alfonsogarciacaro I removed yarn.lock and package.json, but I am not sure what to do about there being 2 README.md files.