fac-13 / HyGiJeJe

Web app with 2 api's
1 stars 0 forks source link

Test issues #24

Open helenzhou6 opened 6 years ago

helenzhou6 commented 6 years ago

Hey! Nice site πŸ‘πŸ˜ŠAPIs are a pain (especially if the response you get back is a mess) so well done! You've managed to get a lot of information from the API too, which is awesome!

A few issues regarding your test.js file:

helenzhou6 commented 6 years ago

Your code coverage may be low because of the wikipedia API code not being used πŸ€”(possibly)

vlbee commented 6 years ago

I believe the test coverage is low because you are currently only making one API call so don't actually have code that half the tests are meant to cover?? not sure. The Wikipedia tests aren't testing anything I think for the time being.

vlbee commented 6 years ago

Also you have some duplicate tests -

image

helenzhou6 commented 6 years ago

(Also love the use of test doubles πŸ‘)