Open helenzhou6 opened 6 years ago
Your code coverage may be low because of the wikipedia API code not being used π€(possibly)
I believe the test coverage is low because you are currently only making one API call so don't actually have code that half the tests are meant to cover?? not sure. The Wikipedia tests aren't testing anything I think for the time being.
Also you have some duplicate tests -
(Also love the use of test doubles π)
Hey! Nice site ππAPIs are a pain (especially if the response you get back is a mess) so well done! You've managed to get a lot of information from the API too, which is awesome!
A few issues regarding your test.js file:
Looks like your tests are failing right now, I can't quite tell why (sorry)
Unfortunately your test coverage is quite low, perhaps look at your logic.js functions and see what tests could still be written.
Looks like you've used
deepEquals
in some of your tests (see below) when it is not objects you are comparing. I'm not sure if it makes a difference π€ but FYI. https://github.com/fac-13/HyGiJeJe/blob/c352f0bf133aed7e14cb3ab014700507ef99cfff/test.js#L26-L38