search

facebookarchive / flashback

Capture and replay real mongodb workloads
Other
217 stars 72 forks source link

pcap_converter: add mongoproto.OpDelete, mongoproto.OpUpdate and mongoproto.OpGetMore operations once available #40

Closed timvaillancourt closed 7 years ago

timvaillancourt commented 7 years ago

Delete, Update and GetMore operations don't work with pcapconverter because github.com/tmc/mongoproto does not have a complete set of methods (.FromReader(), .OpCode() and .String())_ for these types.

I've started to fix this on tmc/mongoproto on this branch of mongoproto: https://github.com/timvaillancourt/mongoproto/tree/update_delete_fromreaders.

This issue is a placeholder to remind me (or someone) to add Delete, Update and GetMore (if that's even possible) to pcap_converter once tmc/mongoproto supports it.

tmc commented 7 years ago

@timvaillancourt please do submit PRs on that other repo

timvaillancourt commented 7 years ago

Sure thing @tmc. I'll finish drafting it up and I might bug you for some ideas later - I got some code started but for some reason I couldn't get valid bson out of the update/delete packets. I think there is just more data in the payload I'm not reading yet but we'll see.

timvaillancourt commented 7 years ago

Update: A PR to support opUpdate and opDelete is ready at https://github.com/tmc/mongoproto/pull/2.