search

facebookresearch / balance

The balance python package offers a simple workflow and methods for dealing with biased data samples when looking to infer from them to some target population of interest.
https://import-balance.org
GNU General Public License v2.0
681 stars 40 forks source link

Relax `seaborn` pin #64

Closed dhirschfeld closed 1 year ago

dhirschfeld commented 1 year ago

This is preventing me from installing balance in an analytics env so I thought I'd put in a PR to see if it broke anything.

The latest seaborn is v0.12.2.

facebook-github-bot commented 1 year ago

Hi @dhirschfeld!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

dhirschfeld commented 1 year ago

In case you want to simply merge this PR I have signed the CLA.

talgalili commented 1 year ago

Thanks. Running the checks now, let's see if it works.

dhirschfeld commented 1 year ago

Just confirming that it is testing the new version:

image

facebook-github-bot commented 1 year ago

@talgalili has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@talgalili merged this pull request in facebookresearch/balance@4cc0c02c0e103d02acc901f003a0564ecfa11542.

talgalili commented 1 year ago

Hey @dhirschfeld

We've merged the PR. Could you please install balance from github and see if it works for you? Especially, if you get to it, could you try to run the quick start notebook example to verify the static plots are working? (Because if not we'll need to either revert or add some fixes)

Thanks :)