search

facebookresearch / balance

The balance python package offers a simple workflow and methods for dealing with biased data samples when looking to infer from them to some target population of interest.
https://import-balance.org
GNU General Public License v2.0
686 stars 42 forks source link

Add scipy empty #90

Closed lizgzil closed 2 weeks ago

lizgzil commented 2 weeks ago

Trying to fix the scipy empty problem that we had by monkey-patching it in a similar way to the scipy.random issue

"...asf_heat_pump_suitability/lib/python3.10/site-packages/glmnet_python/glmnetPredict.py", line 110, in <module>
    newx = scipy.empty([0]), \
  File ".../miniconda3/envs/asf_heat_pump_suitability/lib/python3.10/site-packages/scipy/__init__.py", line 139, in __getattr__
    raise AttributeError(
AttributeError: Module 'scipy' has no attribute 'empty'
facebook-github-bot commented 2 weeks ago

Hi @lizgzil!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

lizgzil commented 2 weeks ago

sorry - I should have put this in our forked repo!! https://github.com/nestauk/balance

talgalili commented 2 weeks ago

Hi @lizgzil and @sqr00t If you found a solid way to solve this issue, please feel free to submit a PR, and I'll gladly review it. Thanks :)