search

facebookresearch / phyre

PHYRE is a benchmark for physical reasoning.
https://phyre.ai
Apache License 2.0
430 stars 61 forks source link

Python 3.8 Version #47

Closed aks2203 closed 2 years ago

aks2203 commented 3 years ago

Hi there, I'm interested in using Phyre for a project that is in Python 3.8. I can easily pip install the package in a 3.6 env, but not a 3.8 env. Is there anything that would break in 3.8? Can the package be updated to handle this?

akhti commented 3 years ago

Hey! Everything should work. Could you try these instructions: https://github.com/facebookresearch/phyre/blob/master/INSTALLATION.md#installation-from-source

But edit https://github.com/facebookresearch/phyre/blob/master/env.yml to use python 3.8?

aks2203 commented 3 years ago

Hi, thanks for the quick reply. The build from source instructions are leading to errors like "npm not found". While I can install everything needed to build locally, pip seems to build seamlessly in a 3.6 env. For my use case, I think it's easier to move to 3.6 so I'll do that for this project. Thank you for the help!

ZhiyuanChen commented 2 years ago

I have successfully built a package with python setup.py develop Can I ask how to build it for release? @akhti python setup.py sdist seems not working

akhti commented 2 years ago

I've built wheels for python versions 3.{6,7,8,9} and also added instructions on how to build things for these versions from scratch. Hope this helps