Possible issue in eval_loss

facebookresearch / phyre

PHYRE is a benchmark for physical reasoning.

https://phyre.ai

Apache License 2.0

431 stars 64 forks source link

Possible issue in eval_loss #55

Closed laknath closed 2 years ago

laknath commented 3 years ago

I'm not sure if the indexing logic in eval_loss (in neural_agent.py line 397, 398), using two task_indices is correct. Perhaps I got it wrong, but just in case. Thank you.

https://github.com/facebookresearch/phyre/blob/2c5247944cfbf9730159da9181d1d6a937362dce/agents/neural_agent.py#L397