facebookresearch / phyre

PHYRE is a benchmark for physical reasoning.
https://phyre.ai
Apache License 2.0
430 stars 61 forks source link

Possible Issue with refine_actions #8

Closed keeganharris closed 5 years ago

keeganharris commented 5 years ago

In line 161 of neural_agent.py (in refine_actions), the cross entropy loss is calculated between the logits and a tensor of ones with length len(actions). Wouldn't it make more sense for the length to be len(action_batch)? In the present case, the code only runs without error if the values for the dqn-eval-batch-size and dqn-rank-size flags are equal.

akhti commented 5 years ago

Thanks, that's true. Not that we don't use action refining in any of the agents in the paper as we didn't see any clear improvement from doing that.