search

faceyspacey / redux-first-router-link

<Link /> + <NavLink /> that mirror react-router's + a few additional props
MIT License
55 stars 33 forks source link

Fix react-redux 6.0.0 new way of passing context #113

Closed GuillaumeCisco closed 5 years ago

GuillaumeCisco commented 5 years ago

Fix https://github.com/faceyspacey/redux-first-router-link/issues/101

ScriptedAlchemy commented 5 years ago

assessing multiple PRs regarding the same fix, checking with authors of those prs if there's anything they want to review on this one

ScriptedAlchemy commented 5 years ago

If still relevant @GuillaumeCisco @cdoublev

Please merge with master and resolve conflicts, then ill merge it if the community (you guys) say yes

ScriptedAlchemy commented 5 years ago

Ill merge this if we can resolve the conflicts. Otherwise give me like 4 hours and ill do so on my machine. Again I’m really sorry i got PR's mixed up

cdoublev commented 5 years ago

Sounds more efficient that I let you both handle that from your own PR/repository. I should probably have closed my PR @ScriptedAlchemy: also my fault.

GuillaumeCisco commented 5 years ago

Thanks @cdoublev and @ScriptedAlchemy. As we are in Christmas days, I cannot access a computer right now. I will in 2 days. If someone can make a PR from this PR, it will be great! We could merge it from GitHub gui :)

ScriptedAlchemy commented 5 years ago

Sure thing I'll update your pr tomorrow and merge. Tomorrow is my last day before family vacation to the mountains. No idea what wireless service is there. So I'll make sure this is merge tomorrow. Merry Christmas or happy holidays!!!

GuillaumeCisco commented 5 years ago

Just got some time to rebase it :) Happy Holidays :)

ScriptedAlchemy commented 5 years ago

:tada: This PR is included in version 2.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ScriptedAlchemy commented 5 years ago

Checking in here, we all good?

cdoublev commented 5 years ago

Yes, thank you both. I just updated it with react-redux: links are working correctly. 👍

ScriptedAlchemy commented 5 years ago

Thanks guys. I really appreciatate it!