search

faceyspacey / redux-first-router-link

<Link /> + <NavLink /> that mirror react-router's + a few additional props
MIT License
55 stars 33 forks source link

A link from a page with a hash to a page without a hash doesn't update the URL bar #89

Closed edahlseng closed 6 years ago

edahlseng commented 6 years ago

If I'm on a URL with a hash (say, /store/fruits/apple#pricing) and I click a link that points to a route without a tab (example shown below), clicking that link will correctly fire the redux action, but it won't update the URL bar.

const routesMap = {
    FRUIT_NO_TAB: '/store/fruit/:fruitName'
}
<NavLink to={{type: 'FRUIT_NO_TAB', payload: {fruitName: 'apple'}} activeClassName="active">Top of page</NavLink>
faceyspacey commented 6 years ago

coming in Rudy. a few more weeks out.